POC drop changes during publish inside deleted parts #5462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #4997 by silently dropping unapplicable changes where its assumed their parent has been deleted.
Now this is not a trivial task and might be after all a bad choice with unexpected behaviour.
As we don't want to expensively find out which published remove nodes overshadowed changes in the tree we simply make the assumption that any unapplicable change because their target node id cannot be found can be drooped. Almost.
Now there are exceptions to the rule. For example #5364 shows that moving a node out of a tree which is later deleted and published first is certainly an expected behaviour. Here this change must not be dropped.
So a more solid solution could do the following when a remaining change fails to apply:
One more note: Because of dimensions dropping changes is not trivial at all. For example a remove node is allowed to target only
STRATEGY_ALL_SPECIALIZATIONS
while an overshadowed creation or variant creations could affect other dimensions where the change should still prevail.Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions