Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Handle publish individual nodes scope in core via simulation #5461

Draft
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 6, 2025

Attempts to implement "gather nodes to publish during simulation" from #5459 (comment)

PublishIndividualNodesFromWorkspace::create(
    $workspaceName,
    $siteId,
    NodeTypeNameFactory::forSite()
)

That indeed fixes the problem with publishing with the removals ... but so far the logic is broken for other things like moves as there the last position counts ... so not easy after all. Also i found out that we cannot use findClosestNode as we operate on the content graph ... so need a new method (see findClosestAncestorNodeAggregate)

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Feb 6, 2025
@mhsdesign mhsdesign changed the title WIP handle-publish-individual-nodes-scope-in-core POC Handle publish individual nodes scope in core via simulation Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant