feat: send projectId and branchId to Segment #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PlayLikeNeverB4 this PR also seems to include some commits that are not part of this change |
|
That's probably my fault, I had to fix main with force-push :3 |
PlayLikeNeverB4
force-pushed
the
george/track-project-id
branch
from
fbc8893 to
ca48d1d
Compare
|
Fixed it |
duskpoet
reviewed
Dec 19, 2024
|
@duskpoet I implemented your suggestion. Also noticed that I needed to treat |
duskpoet
approved these changes
Dec 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
Relates to neondatabase/cloud#20941 Because the `cli_started` event is sent at the beginning we can't know the resource ids. So I added a `cli_command_success` event after the command runs when we have the final context. These will not be sent on error because I couldn't find a way to get the context on error. ### **Examples** `neon branches list` will send `projectId` `neon branches get someid` will send `projectId` and `branchId` `neon branches get main` will send `projectId` and correct `branchId` `branches restore A B` will send `projectId` and `branchId=A` `neon me` will send both as `undefined`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/neondatabase/cloud/issues/20941
Because the
cli_startedevent is sent at the beginning we can't know the resource ids.So I added a
cli_command_successevent after the command runs when we have the final context.These will not be sent on error because I couldn't find a way to get the context on error.
Examples
neon branches listwill sendprojectIdneon branches get someidwill sendprojectIdandbranchIdneon branches get mainwill sendprojectIdand correctbranchIdbranches restore A Bwill sendprojectIdandbranchId=Aneon mewill send both asundefined