Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix husky #127

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: fix husky #127

merged 1 commit into from
Dec 4, 2023

Conversation

amitdahan
Copy link
Contributor

@amitdahan amitdahan commented Dec 3, 2023 •
edited
Loading

Apparently we lost the prepare npm script that makes husky work for anyone who installs the project locally, so I managed to overcome it 😅

@amitdahan amitdahan requested a review from duskpoet December 3, 2023 09:13
duskpoet
duskpoet reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@duskpoet duskpoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure this script won't be triggered when you install neonctl globally?

@amitdahan
Copy link
Contributor Author

That would be postinstall, but let me ensure that prepare doesn't affect consuming workspaces

@amitdahan
Copy link
Contributor Author

typicode/husky#884

Yeah seems prepare will not behave like postintall, as in - it'll only happen during development of a package, not when consuming it externally.

@duskpoet
Copy link
Member

duskpoet commented Dec 4, 2023

Awesome, thanks!

@amitdahan amitdahan merged commit 145af86 into main Dec 4, 2023
1 check passed
@amitdahan amitdahan deleted the fix-husky branch December 4, 2023 12:51
duskpoet pushed a commit that referenced this pull request Dec 8, 2023
@amitdahan @duskpoet
fix: fix husky (#127)
efd5af0
duskpoet pushed a commit that referenced this pull request Dec 8, 2023
@semantic-release-bot
chore(release): 1.24.1 [skip ci]
c0e87fd 
## [1.24.1](v1.24.0...v1.24.1) (2023-12-08)

### Bug Fixes

* fix husky ([#127](#127)) ([efd5af0](efd5af0))
* support for an update to the branch id format ([#128](#128)) ([3d5e8f0](3d5e8f0))
* update commitlint rules ([f260ae6](f260ae6))
duskpoet pushed a commit that referenced this pull request Dec 8, 2023
@semantic-release-bot
chore(release): 1.24.1 [skip ci]
5986146 
## [1.24.1](v1.24.0...v1.24.1) (2023-12-08)

### Bug Fixes

* fix husky ([#127](#127)) ([efd5af0](efd5af0))
* support for an update to the branch id format ([#128](#128)) ([3d5e8f0](3d5e8f0))
* update commitlint rules ([f260ae6](f260ae6))
duskpoet pushed a commit that referenced this pull request Dec 8, 2023
@amitdahan @duskpoet
fix: fix husky (#127)
22823b4
duskpoet pushed a commit that referenced this pull request Dec 8, 2023
@semantic-release-bot
chore(release): 1.24.1 [skip ci]
e9d6e66 
## [1.24.1](v1.24.0...v1.24.1) (2023-12-08)

### Bug Fixes

* fix husky ([#127](#127)) ([22823b4](22823b4))
* support for an update to the branch id format ([#128](#128)) ([4f59d88](4f59d88))
* update commitlint rules ([119acd7](119acd7))
* update prepare script to execute only when .git exists ([c9637c6](c9637c6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duskpoet duskpoet duskpoet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitdahan @duskpoet