-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy error reworking #6453
Merged
Merged
Proxy error reworking #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2418 tests run: 2305 passed, 0 failed, 113 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
3bbc545 at 2024-02-09T15:38:41.835Z :recycle: |
1a86ea6
to
0fa223a
Compare
977c54e
to
ebf183d
Compare
87b1383
to
797e60d
Compare
ebf183d
to
dd825cd
Compare
3c2fdd1
to
ce3f99f
Compare
dd825cd
to
b95a55c
Compare
f22bf05
to
3db668a
Compare
ef241cd
to
7a91c6e
Compare
7f5a17b
to
e676524
Compare
e676524
to
d7be26f
Compare
remove some of the extra checks for sni hostnames that dont seem too necessary
khanova
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few minor questions.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Taking my ideas from #6283 and doing a bit less radical changes. smaller commits.
We currently don't report error classifications in proxy as the current error handling made it hard to do so.
Summary of changes
ReportableError
trait that all errors will implement. This provides the error classification functionality.ReportableError
and is logged appropriatelyChecklist before requesting a review
Checklist before merging