Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: expose prometheus metrics for startup time #4893

Merged
merged 14 commits into from
Aug 8, 2023
Merged

pageserver: expose prometheus metrics for startup time #4893

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6707d58
pageserver: expose prometheus metrics for startup time
jcsp Aug 3, 2023
f46ec6d
switch to f64 secs for startup time metric
jcsp Aug 4, 2023
4798976
move "complete" checkpoint to end of function
jcsp Aug 4, 2023
d68d189
Add tenant activation duration histogram
jcsp Aug 4, 2023
19949a4
Add 0/1 metric for when in initial tenant load
jcsp Aug 4, 2023
31c0731
tweak new metrics names (_seconds instead of _secs)
jcsp Aug 4, 2023
16b50d9
Revert "move "complete" checkpoint to end of function"
jcsp Aug 7, 2023
734e668
reinstate elapsed_millis on startup log lines
jcsp Aug 7, 2023
87eb8c7
cargo fmt
jcsp Aug 8, 2023
3ce314c
Add test coverage for startup metrics in existing restart test
jcsp Aug 8, 2023
7694d5e
fix metric description
jcsp Aug 8, 2023
6dc8966
python lint
jcsp Aug 8, 2023
de270be
remove unneeded F64GaugeVec (plain GaugeVec is F64)
jcsp Aug 8, 2023
6d04359
Update pageserver/src/bin/pageserver.rs
jcsp Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pageserver/src/bin/pageserver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,6 @@ fn start_pageserver(

}

startup_checkpoint("complete", "Startup complete");
};

async move {
Expand Down Expand Up @@ -574,6 +573,7 @@ fn start_pageserver(
);
}

startup_checkpoint("complete", "Startup complete");
let mut shutdown_pageserver = Some(shutdown_pageserver.drop_guard());

// All started up! Now just sit and wait for shutdown signal.
Expand Down