refactor: just one way to shutdown a tenant #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Jun 2, 2023
koivunej
commented
Jun 2, 2023
1004 tests run: 964 passed, 0 failed, 40 skipped (full report)Flaky tests (10)Postgres 15
Postgres 14
The comment gets automatically updated with the latest test results
af801ba at 2023-06-06T12:29:45.678Z :recycle: |
also make it non-pub, it shouldn't be called from anywhere except shutdown.
good thing is that during the 10s most of the tenants and timelines would had completed stopping. one could consider if we should have a timeout here, but the shutdown freeze_and_flush operations are best-effort. However, if a timeline_delete is already ongoing, perhaps we should never attempt to flush it. this is however already tracked by flush loop being shut down, so there is no need for more changes.
Looks flaky. |
koivunej
requested review from
lubennikovaav,
bojanserafimov,
problame and
LizardWizzard
and removed request for
a team and
lubennikovaav
LizardWizzard
approved these changes
Jun 5, 2023
LizardWizzard
approved these changes
Jun 6, 2023
awestover
pushed a commit
that referenced
this pull request
Jun 14, 2023
We have 2 ways of tenant shutdown, we should have just one. Changes are mostly mechanical simple refactorings. Added `warn!` on the "shutdown all remaining tasks" should trigger test failures in the between time of not having solved the "tenant/timeline owns all spawned tasks" issue. Cc: #4327.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have 2 ways of tenant shutdown, we should have just one.
Cc: #4327.
Summary of changes
Mostly mechanical simple refactorings.
Added
warn!on the "shutdown all remaining tasks" should trigger test failures in the between time of not having solved the "tenant/timeline owns all spawned tasks" issue.Checklist before requesting a review
Checklist before merging