Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broker duration logs with metrics #4370

Merged
merged 3 commits into from
May 30, 2023

Conversation

petuhovskiy
Copy link
Member

@petuhovskiy petuhovskiy commented May 30, 2023

Summary of changes

I've added logs for broker push duration after every iteration in #4142. This log has not found any real issues, so we can replace it with metrics, to slightly reduce log volume.

LogQL query found that pushes longer that 500ms happened only 90 times for the last month. https://neonprod.grafana.net/goto/KTNj9UwVg?orgId=1

{unit="safekeeper.service"} |= "timeline updates to broker in" | regexp "to broker in (?P<duration>.*)" | duration > 500ms

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@petuhovskiy petuhovskiy requested a review from a team as a code owner May 30, 2023 10:53
@petuhovskiy petuhovskiy requested review from arssher and removed request for a team May 30, 2023 10:53
safekeeper/src/broker.rs Show resolved Hide resolved
safekeeper/src/metrics.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

1004 tests run: 963 passed, 0 failed, 41 skipped (full report)


The comment gets automatically updated with the latest test results
1115897 at 2023-05-30T11:46:31.434Z :recycle:

@petuhovskiy petuhovskiy merged commit 210be6b into main May 30, 2023
@petuhovskiy petuhovskiy deleted the sk-dont-log-broker-duration branch May 30, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants