Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage: store lcov report #4358

Merged
merged 1 commit into from
May 30, 2023
Merged

Code Coverage: store lcov report #4358

merged 1 commit into from
May 30, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented May 26, 2023

Problem

In the future, we want to compare code coverage on a PR with coverage on the main branch.
Currently, we store only code coverage HTML reports, I suggest we start storing reports in "lcov info" format that we can use/parse in the future. Currently the file size is ~7Mb (it's a text-based format and could be compressed into a ~400Kb archive)

Summary of changes

  • Change scripts/coverage to output lcov coverage to report/lcov.info file instead of stdout (we already upload the whole report/ directory to S3)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions
Copy link

github-actions bot commented May 26, 2023

1004 tests run: 964 passed, 0 failed, 40 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_get_tenant_size_with_multiple_branches: ✅ release
  • test_pageserver_lsn_wait_error_safekeeper_stop: ✅ release
The comment gets automatically updated with the latest test results
f26f9b0 at 2023-05-26T16:07:23.323Z :recycle:

@bayandin bayandin merged commit daa79b1 into main May 30, 2023
@bayandin bayandin deleted the bayandin/store-lcov-report branch May 30, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants