Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable file cache integration for VM compute node #4338

Merged
merged 1 commit into from
May 28, 2023

Conversation

sharnoff
Copy link
Member

Problem

#4155 inadvertently switched to a version of the VM builder that leaves the file cache integration disabled by default.

Summary of changes

Re-enable the file vm-informant's file cache integration.

(as a refresher: The vm-informant is the autoscaling component that sits inside the VM and manages postgres / compute_ctl)

See also: neondatabase/autoscaling#265

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@sharnoff sharnoff requested a review from vadim2404 May 24, 2023 17:15
@github-actions
Copy link

github-actions bot commented May 24, 2023

1000 tests run: 960 passed, 0 failed, 40 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_ondemand_download_timetravel[real_s3]: ✅ release

Postgres 14

The comment gets automatically updated with the latest test results
da1cf91 at 2023-05-24T18:37:03.364Z :recycle:

@sharnoff sharnoff merged commit ccf653c into main May 28, 2023
@sharnoff sharnoff deleted the sharnoff/neonvm-builder-enable-file-cache branch May 28, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants