Rename "Postgres nodes" in control_plane to endpoints. #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
requested review from
a team,
lubennikovaav and
LizardWizzard
and removed request for
a team
hlinnaka
force-pushed
the
neon_local-endpoints
branch
7 times, most recently
from
56bf5b4 to
da73f68
Compare
hlinnaka
requested review from
a team and
NanoBjorn
and removed request for
a team
Test results for 1ce670a:debug build: 212 tests run: 202 passed, 0 failed, 10 (full report)release build: 212 tests run: 202 passed, 0 failed, 10 (full report) |
hlinnaka
force-pushed
the
move-compute-spec
branch
from
b410af5 to
8e06018
Compare
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
da73f68 to
1f2946a
Compare
This was referenced Apr 5, 2023
hlinnaka
force-pushed
the
move-compute-spec
branch
from
8e06018 to
939ea29
Compare
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
1f2946a to
1326ccc
Compare
hlinnaka
force-pushed
the
move-compute-spec
branch
2 times, most recently
from
1f2df18 to
f0b2e07
Compare
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
1326ccc to
d823c15
Compare
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
d823c15 to
50e38f5
Compare
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
50e38f5 to
7f4f29e
Compare
koivunej
reviewed
Apr 13, 2023
There was a problem hiding this comment.
The biggest problem is mental migration, and maybe someone has scripts. We could assist with that while accumulating 1 line of code to make a question on slack unnecessary.
Aside from these ... I think it looks good if the tests pass? :) I can't say I read through everything.
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
7f4f29e to
4c20605
Compare
koivunej
approved these changes
Apr 13, 2023
|
The regress test failure was a #2962 I think: |
We use the term "endpoint" in for compute Postgres nodes in the web UI
and user-facing documentation now. Adjust the nomenclature in the code.
This changes the name of the "neon_local pg" command to "neon_local
endpoint". Also adjust names of classes, variables etc. in the python
tests accordingly.
This also changes the directory structure so that endpoints are now
stored in:
.neon/endpoints/<endpoint id>
instead of:
.neon/pgdatadirs/tenants/<tenant_id>/<endpoint (node) name>
The tenant ID is no longer part of the path. That means that you
cannot have two endpoints with the same name/ID in two different
tenants anymore. That's consistent with how we treat endpoints in the
real control plane and proxy: the endpoint ID must be globally unique.
hlinnaka
force-pushed
the
neon_local-endpoints
branch
from
4c20605 to
1ce670a
Compare
|
Pushed, thanks for the review, @koivunej ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the term "endpoint" in for compute Postgres nodes in the web UI
and user-facing documentation now. Adjust the nomenclature in the code.
This changes the name of the "neon_local pg" command to "neon_local
endpoint". Also adjust names of classes, variables etc. in the python
tests accordingly.
This also changes the directory structure so that endpoints are now
stored in:
instead of:
The tenant ID is no longer part of the path. That means that you
cannot have two endpoints with the same name/ID in two different
tenants anymore. That's consistent with how we treat endpoints in the
real control plane and proxy: the endpoint ID must be globally unique.
(This is extracted to separate PR from PR #3886, and developed further to also rename the 'neon_local pg' command to 'neon_local endpoint', and all the changes in the python test)