Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(pg-clients): fix logical replication tests #10623

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Feb 1, 2025

Problem

Tests for logical replication (on Staging) have been failing for some time because logical replication is not enabled for them. This issue occurred after switching to an org API key with a different default setting, where logical replication was not enabled by default.

Summary of changes

  • Add enable_logical_replication input to actions/neon-project-create
  • Enable logical replication in test-logical-replication job

@bayandin bayandin requested a review from a-masterov February 1, 2025 15:02
@bayandin bayandin requested a review from a team as a code owner February 1, 2025 15:02
Copy link

github-actions bot commented Feb 1, 2025

7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)


Code coverage* (full report)

  • functions: 33.3% (8523 of 25632 functions)
  • lines: 49.0% (71484 of 145930 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c766702 at 2025-02-03T10:31:41.422Z :recycle:

Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bayandin bayandin force-pushed the bayandin/fix-logical-replication-tests branch from 6297dad to c766702 Compare February 3, 2025 09:30
@bayandin bayandin added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 4368262 Feb 3, 2025
92 checks passed
@bayandin bayandin deleted the bayandin/fix-logical-replication-tests branch February 3, 2025 13:43
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
## Problem

Tests for logical replication (on Staging) have been failing for some
time because logical replication is not enabled for them. This issue
occurred after switching to an org API key with a different default
setting, where logical replication was not enabled by default.

## Summary of changes
- Add `enable_logical_replication` input to
`actions/neon-project-create`
- Enable logical replication in `test-logical-replication` job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants