Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: force-compact in test_sharding_autosplit #10605

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

erikgrinaker
Copy link
Contributor

Problem

This test may not fully detect data corruption during splits, since we don't force-compact the entire keyspace.

Summary of changes

Force-compact all data in test_sharding_autosplit.

@erikgrinaker erikgrinaker requested a review from jcsp January 31, 2025 10:04
Copy link

7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)


Code coverage* (full report)

  • functions: 33.4% (8518 of 25538 functions)
  • lines: 49.1% (71514 of 145568 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e17b6bd at 2025-01-31T11:19:29.387Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit afbcebe Jan 31, 2025
84 checks passed
@erikgrinaker erikgrinaker deleted the erik/test-split-force-compact branch January 31, 2025 11:38
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
…#10605)

## Problem

This test may not fully detect data corruption during splits, since we
don't force-compact the entire keyspace.

## Summary of changes

Force-compact all data in `test_sharding_autosplit`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants