Skip to content

Commit

Permalink
test: fix flaky warning on attach (#4415)
Browse files Browse the repository at this point in the history
added the `allowed_error` to the `positive_env` so any tests completing
the attach are allowed have this print out. they are allowed to do so,
because the `random_init_delay` can produce close to zero and thus the
first run will be near attach. Though... Unsure if we ever really need
the eviction task to run **before** it can evict something, as in after
20min or 24h.

in the failed test case however period is 20s so interesting that we
didn't run into this sooner.

evidence of flaky:
https://github.com/neondatabase/neon/actions/runs/5175677035/jobs/9323705929?pr=4399#step:4:38536
  • Loading branch information
koivunej authored Jun 5, 2023
1 parent 77598f5 commit e0bd81c
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test_runner/regress/test_attach_tenant_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ def positive_env(neon_env_builder: NeonEnvBuilder) -> NeonEnv:
test_name="test_attach_tenant_config",
)
env = neon_env_builder.init_start()

# eviction might be the first one after an attach to access the layers
env.pageserver.allowed_errors.append(
".*unexpectedly on-demand downloading remote layer remote.* for task kind Eviction"
)
assert isinstance(env.remote_storage, LocalFsStorage)
return env

Expand Down

1 comment on commit e0bd81c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1071 tests run: 1023 passed, 0 failed, 48 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_remote_storage_upload_queue_retries[local_fs]: ✅ debug
The comment gets automatically updated with the latest test results
e0bd81c at 2023-06-05T16:12:06.995Z :recycle:

Please sign in to comment.