Skip to content

Commit

Permalink
Allow pageserver unreachable errors in test_scrubber_tenant_snapshot (#…
Browse files Browse the repository at this point in the history
…10585)

## Problem

test_scrubber_tenant_snapshot restarts pageservers, but log validation
fails tests on any non white listed storcon warnings, making the test
flaky.

## Summary of changes

Allow warns like
2025-01-29T12:37:42.622179Z WARN reconciler{seq=1
tenant_id=2011077aea9b4e8a60e8e8a19407634c shard_id=0004}: Call to node
2 (localhost:15352) management API failed, will retry (attempt 1):
receive body: error sending request for url
(http://localhost:15352/v1/tenant/2011077aea9b4e8a60e8e8a19407634c-0004/location_config):
client error (Connect)

ref #10462
  • Loading branch information
arssher authored Jan 31, 2025
1 parent 6041a93 commit 765ba43
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test_runner/regress/test_storage_scrubber.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ def test_scrubber_tenant_snapshot(neon_env_builder: NeonEnvBuilder, shard_count:
neon_env_builder.num_pageservers = shard_count if shard_count is not None else 1

env = neon_env_builder.init_start()
# We restart pageserver(s), which will cause storage storage controller
# requests to fail and warn.
env.storage_controller.allowed_errors.append(".*management API still failed.*")
env.storage_controller.allowed_errors.append(
".*Reconcile error.*error sending request for url.*"
)
tenant_id = env.initial_tenant
timeline_id = env.initial_timeline
branch = "main"
Expand Down

1 comment on commit 765ba43

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7565 tests run: 7202 passed, 1 failed, 362 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_download_churn[release-pg16-github-actions-selfhosted-100-tokio-epoll-uring-30]"
Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 33.3% (8516 of 25538 functions)
  • lines: 49.1% (71512 of 145568 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
765ba43 at 2025-01-31T13:04:17.392Z :recycle:

Please sign in to comment.