Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command with complete but no nargs #3211

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Fix command with complete but no nargs #3211

merged 3 commits into from
Jul 13, 2021

Conversation

perrin4869
Copy link
Contributor

Maybe it's better to target master branch?
Reference: vim/vim#8544
Closes #3209

@chemzqm
Copy link
Member

chemzqm commented Jul 12, 2021

You need to change -nargs=0 to -nargs=? instead

@perrin4869
Copy link
Contributor Author

Hm... I was going off of tpope/vim-fugitive@4cdeff8, there the nargs remained intact... Made the change here though

@chemzqm
Copy link
Member

chemzqm commented Jul 12, 2021

And keep -complete=custom,coc#list#names

@chemzqm chemzqm merged commit fb123ed into neoclide:master Jul 13, 2021
@jenhsun jenhsun mentioned this pull request Jul 13, 2021
Closed
@Whitecx Whitecx mentioned this pull request Jul 13, 2021
Closed
chemzqm added a commit that referenced this pull request Jul 15, 2021
@chemzqm
commit c02be2e
a72b075 
c02be2e fix(extensions): isActive should not true during activate
76f407d refactor(plugin): disable semantic highlights by default
a56c2e8 fix(completion): use triggerCharacter for manual invoke
fb123ed Fix command with complete but no nargs (#3211)
@luisdavim luisdavim mentioned this pull request Jul 16, 2021
Closed
@pastgonex
Copy link

You need to change -nargs=0 to -nargs=? instead
thank you!

@PartyLich PartyLich mentioned this pull request Oct 18, 2021
Closed
pld-gitsync pushed a commit to pld-linux/vim-plugin-coc that referenced this pull request Nov 4, 2021
@jpalus
upstream fix for "E1208: -complete used without allowing arguments"; …
87427a0 
…rel 2

from neoclide/coc.nvim#3211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perrin4869 @chemzqm @pastgonex