Restructuration of Driver in Modules #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.3-extracting-modules
branch
2 times, most recently
from
9ce742e to
17d0c89
Compare
bigmontz
force-pushed
the
4.3-extracting-modules
branch
from
2465344 to
ee31166
Compare
bigmontz
force-pushed
the
4.3-extracting-modules
branch
2 times, most recently
from
51cd057 to
c6d0a17
Compare
bigmontz
force-pushed
the
4.3-extracting-modules
branch
from
1cd5d0c to
ec3aa5c
Compare
The segmentation of the core module is part of the effort of reduce the size of the bundle for web application. On the core module, all the driver async interface will be defined and implemented in typescript, the details of the bolt protocol, pooling and packstream is not part of this core module. The core package will be bundled together with `neo4j-driver`.
Create connection holder and connections interfaces, and create the observers interface
bigmontz
force-pushed
the
4.3-extracting-modules
branch
6 times, most recently
from
fafe04b to
aa164d5
Compare
bigmontz
force-pushed
the
4.3-extracting-modules
branch
from
402f3ea to
cb80775
Compare
This was
linked to
issues
Mar 9, 2021
Closed
This was
linked to
issues
Mar 9, 2021
bigmontz
changed the title
The segmentation of the bolt-connection module is part of the effort of reduce the size of the bundle for web application. On the bolt-connection module, all the connection and connection provider details are implemented. Chunking, Pool, Routing, Bolt Protocol, etc. This segmentation is part of the effort to modularise better the driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segmentation of the core module is part of the effort of reduce the size of the bundle for web application.
On the
coremodule, all the driver async interface will be defined and implemented in typescript, the details of the bolt protocol, pooling and packstream is not part of this core module.bolt-connectionmodule is responsible for implementing the connectivity details. The bolt protocol, handshake, packstream, connection pool, browser-channel and node-channel are defined in this module. It will provide a way to bundle the correct channel for node and browser using the propertybrowseron thepackage.json.The
coreandbolt-connectionpackage will be bundled together withneo4j-driver.Neo4jErrorinTypescriptneo4j-drivercoretogether withneo4j-drivercoreclasses and objects part ofneo4j-driverdocumentationcorepackagebolt-connectionpackage