teskit: Fine tunning stress tests to run in testkit #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the way the url is generated during the stress test enabling to use configurations came from the test environment. Skipping the non-cluster-safe stress test commands to avoid unstable behaviours and flaky tests.
bigmontz
force-pushed
the
4.3-tunning-stress-test
branch
from
57e19b9 to
60fa032
Compare
bigmontz
force-pushed
the
4.3-tunning-stress-test
branch
from
60fa032 to
56c702a
Compare
bigmontz
requested review from
zhenlineo and
2hdddg
and removed request for
zhenlineo
2hdddg
approved these changes
Dec 15, 2020
| @@ -37,7 +37,7 @@ const UNAUTHORIZED_ERROR_CODE = 'Neo.ClientError.Security.Unauthorized' | |||
| const DATABASE_NOT_FOUND_ERROR_CODE = | |||
| 'Neo.ClientError.Database.DatabaseNotFound' | |||
| const SYSTEM_DB_NAME = 'system' | |||
| const DEFAULT_DB_NAME = '' | |||
| const DEFAULT_DB_NAME = null | |||
There was a problem hiding this comment.
Was this discovered with new default db test? I didn't see any failure
There was a problem hiding this comment.
I discovered it when I test against clusters using testkit locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the way the url is generated during the stress test enabling to use configurations came from the test environment.
Skipping the non-cluster-safe stress test commands to avoid unstable behaviours and flaky tests.