Fix TTL parsing when driver configured to use JS numbers #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver can be created with `{disableLosslessIntegers: true}` config.
Then all integer numbers returned in query results will be `Number`
instead of `neo4j.Integer`.
Routing table response parsing code did not expect `Number`s and failed
to parse the TTL entry. This commit fixes parsing by always wrapping
returned value of TTL in a `neo4j.Integer`.
Also improved error messages around routing response parsing to include
the original error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver can be created with
{disableLosslessIntegers: true}config. Then all integer numbers returned in query results will beNumberinstead ofneo4j.Integer.Routing table response parsing code did not expect
Numbers and failed to parse the TTL entry. This PR fixes parsing by always wrapping returned value of TTL in aneo4j.Integer.Also improved error messages around routing response parsing to include the original error message.
Fixes #424