Fix 'padStart is not a function' error in NodeJS 4 and 6 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operator type names have changed. This commit makes the assertions more generic.
Previous Karma version pulled in a polyfill that made it possible to use ES6 and ES7 features in tests. Such features might not be available during runtime and could result in errors. `String#padStart()` is an example of a feature that was used in the code and was added by the Karma polyfill. Tests worked just fine but driver code failed at runtime in older NodeJS versions. Note that Babel runtime that is used by the driver does not polyfill instance methods such as `String#padStart()`.
It might not be available on older NodeJS and browsers. It can't be added by the Babel runtime because it is an instance function. Only Babel polyfill can add such functions and we can't use plyfill because it changes the global scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Karma so that it does not polyfill the test scope with ES6 and ES7 features and makes code not use
String#padStart()which might not be available in older NodeJS versions.