-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema refactoring #261
Schema refactoring #261
Conversation
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 2025-01-28Added
Changed
|
): # Check if the sanitized value is not None | ||
new_dict[key] = sanitized_value | ||
elif isinstance(value, list): | ||
if len(value) < LIST_LIMIT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is performed in value_sanitize
in the isinstance(value, list)
case, do we have to redo it here? Maybe it's the same in the end, because we will have to test for None
return value if we skip this list length test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. This is value_sanitize
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant I think the test on line 113 is redundant, and I have the impression it should work if we remove it because then we enter the _value_sanitize
function with a list as input, and the test on the list length is performed on line 124.
But it's just my impression looking at the code, and it's a minor thing.
6ea2d6d
to
7f1851d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for answering all my questions! Nice work! ⭐
Changelog updates: 🔄 2025-02-05 *Added
Changed
|
Description
Type of Change
Complexity
Complexity: Medium
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):