5.26 LTS clone subgraph properties fix

common/src/main/java/apoc/ApocExtensionFactory.java

@@ -141,7 +141,7 @@ public void start() {
             }
 
             // For APOC extended, the Cypher Procedures listener is both a service and a listener
-            // To stop needing to keep a Map containing it as an object, which stops it being 
+            // To stop needing to keep a Map containing it as an object, which stops it being
             // cleaned up, we check for all APOC services which are also listeners and register them here
             for (Object service : services.values()) {
                 if (service instanceof AvailabilityListener serviceWithAvailabilityListener) {

core/src/main/java/apoc/refactor/GraphRefactoring.java

@@ -321,7 +321,7 @@ private static Node cloneNode(final Transaction tx, final Node node, final Set<S
 
     private static void cloneRel(Relationship base, Node from, Node to, final Set<String> skipProps) {
         final var rel = from.createRelationshipTo(to, base.getType());
-        rel.getAllProperties().forEach((k, v) -> {
+        base.getAllProperties().forEach((k, v) -> {
             if (skipProps.isEmpty() || !skipProps.contains(k)) rel.setProperty(k, v);
         });
     }

core/src/test/java/apoc/refactor/CloneSubgraphTest.java

@@ -466,6 +466,36 @@ public void testCloneSubgraph_With_Standins_For_Node1_Should_Have_RootB() {
                 });
     }
 
+    @Test
+    public void testCloneSubgraph_With_Properties_On_Relationships_Preserved() {
+        try (final var tx = db.beginTx();
+                final var clean = tx.execute("MATCH (n) DETACH DELETE n");
+                final var create = tx.execute("CREATE (:A)-[:R{id:\"ID1\"}]->(:B)");
+                final var clone = tx.execute(
+                        """
+                MATCH (n)-[r:R]->(oldB:B)
+                WITH oldB, COLLECT(DISTINCT n) AS nodes
+                CREATE (newB:B)
+
+                WITH oldB, newB, nodes
+                MATCH (m)-[r]-(n) WHERE n IN nodes
+
+                WITH oldB, newB, nodes, COLLECT(DISTINCT r) AS rels
+                MATCH (s) WHERE NOT s:B
+
+                WITH oldB, newB, nodes, rels, COLLECT(DISTINCT [s, s]) + [[oldB, newB]] AS standinNodes
+                CALL apoc.refactor.cloneSubgraph(nodes, rels, {standinNodes:standinNodes})
+                YIELD input, output
+                MATCH (old) WHERE ID(old) = input
+                CREATE (output)-[r:importedFrom{created_on:datetime()}]->(old)
+
+                RETURN output
+                """);
+                final var res = tx.execute("MATCH (n)-[r]->(m) RETURN r.id AS id"); ) {
+            assertThat(res.stream()).containsExactlyInAnyOrder(Map.of("id", "ID1"), Map.of("id", "ID1"));
+        }
+    }
+
     @Test
     public void
             testCloneSubgraph_With_Standins_For_RootA_And_Oddball_Should_Have_RootB_And_Use_Node_12_In_Place_Of_Oddball() {