Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOID] Formats everything #522

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[NOID] Formats everything #522

merged 2 commits into from
Nov 6, 2023

Conversation

ncordon
Copy link
Collaborator

@ncordon ncordon commented Nov 3, 2023 •
edited
Loading

Uses #520

Why

To have a common style everywhere

@ncordon
Copy link
Collaborator Author

ncordon commented Nov 3, 2023

/spotlessApply

@ncordon ncordon added the NOT READY FOR MERGE PR isn't ready to be merged label Nov 3, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Lojjs Lojjs self-assigned this Nov 6, 2023
Lojjs
Lojjs approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit looks fine. The second one have I not reviewed in detail ofc, but skimming through the first few files, it looks OK.

@ncordon ncordon removed the NOT READY FOR MERGE PR isn't ready to be merged label Nov 6, 2023
@neo4j neo4j deleted a comment from CLAassistant Nov 6, 2023
@ncordon ncordon force-pushed the format-everything branch 3 times, most recently from 1f03f7c to fa78f15 Compare November 6, 2023 14:55
@ncordon
Copy link
Collaborator Author

ncordon commented Nov 6, 2023

/spotlessApply

@ncordon ncordon merged commit 5094e2a into dev Nov 6, 2023
@ncordon ncordon deleted the format-everything branch November 6, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncordon @CLAassistant @Lojjs @neo-technology-build-agent