[rGkwaqu1] apoc.path.expand doesn't handle special characters in label name #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
requested changes
Jun 7, 2023
| @Test | ||
| public void testLabelWithSpecialChar() { | ||
| db.executeTransactionally( | ||
| "CREATE (n:`http://example.com/abc#Object` {one: 'alpha'})-[:REL]->(o:`http://www.w3.org/2002/07/owl#Class`:OwlClass {two: 'beta'})" |
There was a problem hiding this comment.
I would write the test setup slightly different so there are some nodes with e.g. the labels
http + //example.com/abc#Object, only http or other similar cases that should be filtered out by the label filter. That way it would be easier to notice if there are any bugs around this solution.
vga91
force-pushed
the
apoc.path.expand-twodots-chars
branch
from
073a3ff to
ce7677d
Compare
|
CI error fixed here |
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 19, 2023
…l name (neo4j/apoc#415) * [rGkwaqu1] apoc.path.expand doesn't handle special characters in label name * [rGkwaqu1] added tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 20, 2023
…l name (neo4j/apoc#415) * [rGkwaqu1] apoc.path.expand doesn't handle special characters in label name * [rGkwaqu1] added tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Jun 20, 2023
…l name (neo4j/apoc#415) (#3633) * [rGkwaqu1] apoc.path.expand doesn't handle special characters in label name * [rGkwaqu1] added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike what is written in the card,
the issue regards the
:character, which handle compound labels.In this pr I updated the
:char so that an escape character\can be inserted.In case it's ok, the documentation should be updated.
Otherwise, we could just explain better that the
:charis used to handle multiple labels and that it is not possible to filter labels containing that character.