[madSHaLz] APOC triggers aren't updated after a user deletes a database #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
delete-trigger-after-drop-database
branch
from
a23e84c to
6a2fca5
Compare
ncordon
reviewed
Mar 15, 2023
Comment on lines
91
to
95
|
|
||
| // this block is already in system db, so we can directly execute system operation | ||
| // for backward compatibility: clear system nodes at start-up if the corresponding database name doesn't exist | ||
| // placed here instead of e.g. `ApocConfig` because at this point we are sure that all databases are recovered | ||
| cleanUpSystemNodes(); |
There was a problem hiding this comment.
I don't think this is true. Databases are brought up in an eventual consistent way in 5.x so when system is up neo4j could not be up
There was a problem hiding this comment.
Yes indeed it is not safe.
I've been looking for other ways to do this but I don't think there is currently a method that isn't completely error prone, but maybe I'm missing something.
Perhaps it's better not to do this thing at all and document somewhere that for backward compatibility we have to delete the triggers manually. Wdyt?
There was a problem hiding this comment.
Perhaps it's better not to do this thing at all and document somewhere that for backward compatibility we have to delete the triggers manually. Wdyt?
I think that's a better option definitely
ncordon
reviewed
Mar 15, 2023
ncordon
reviewed
Mar 15, 2023
vga91
force-pushed
the
delete-trigger-after-drop-database
branch
from
6a2fca5 to
d7df89d
Compare
vga91
force-pushed
the
delete-trigger-after-drop-database
branch
from
feac91d to
22c9aad
Compare
ncordon
reviewed
Apr 20, 2023
| import static apoc.trigger.TriggerTestUtil.TRIGGER_DEFAULT_REFRESH; | ||
| import static apoc.trigger.TriggerTestUtil.awaitTriggerDiscovered; | ||
| import static apoc.util.TestUtil.waitDbsAvailable; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; |
There was a problem hiding this comment.
I think these imports are not needed anymore?
ncordon
reviewed
Apr 20, 2023
Comment on lines
192
to
210
| // same as above with the database `initDb`, created via apoc.initializer.* | ||
| testCall(sysSession, "CALL apoc.trigger.install($dbName, $name, 'return 1', {})", | ||
| Map.of("dbName", INIT_DB, "name", defaultTriggerName), | ||
| r -> assertEquals(defaultTriggerName, r.get("name")) | ||
| ); | ||
|
|
||
| testCall(sysSession, "CALL apoc.trigger.show($dbName)", | ||
| Map.of("dbName", INIT_DB), | ||
| r -> assertEquals(defaultTriggerName, r.get("name")) | ||
| ); | ||
|
|
||
| // drop database | ||
| sysSession.writeTransaction(tx -> tx.run(String.format("DROP DATABASE %s WAIT;", INIT_DB))); | ||
|
|
||
| // check that the trigger has been removed | ||
| testCallEmpty(sysSession, "CALL apoc.trigger.show($dbName)", | ||
| Map.of("dbName", INIT_DB) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Can you split this into another test please?
ncordon
reviewed
Apr 20, 2023
ncordon
approved these changes
Apr 21, 2023
|
Feel free to merge, we can fix the Snyk issues in another PR, as they are related to dependencies that they've just deemed are insecure |
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Apr 28, 2023
…se (neo4j/apoc#348) * [madSHaLz] APOC triggers aren't updated after a user deletes a database * [madSHaLz] changes review * [madSHaLz] removed no longer valid test * [madSHaLz] split test --------- Co-authored-by: Nacho Cordón <[email protected]>
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
May 5, 2023
…se (neo4j/apoc#348) * [madSHaLz] APOC triggers aren't updated after a user deletes a database * [madSHaLz] changes review * [madSHaLz] removed no longer valid test * [madSHaLz] split test --------- Co-authored-by: Nacho Cordón <[email protected]>
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
May 5, 2023
…se (neo4j/apoc#348) (#3550) * [madSHaLz] APOC triggers aren't updated after a user deletes a database * [madSHaLz] changes review * [madSHaLz] removed no longer valid test * [madSHaLz] split test --------- Co-authored-by: Nacho Cordón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented 3rd solution -
DatabaseEventListener,so that we can delete every system node belonging to the database that we delete.
Added a
cleanUpSystemNodes()for backward compatibility