[0eSjZq6Q] Fix S3 failing flaky tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
fix_flaky_s3_tests
branch
from
4fbab3c to
6272455
Compare
vga91
changed the title
AzuObs
approved these changes
Jan 20, 2023
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Feb 13, 2023
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guess is that sometimes the
localstackcontainer doesn't load the file immediately, hence theThe specified key does not existerror.Hopefully, this could also solve the
zKSByYcV(ExportCypherS3Test.testExportQueryCypherFormatUpdateAll),where I think the file is not immediately overwritten
but a previous
all.cypherfile coming from another test is retrieved.