Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (core) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Looks good to me, just see the comment about cherry-picking. Regarding 'NOTE FOR THE REVIEWER':
- I would not create schema equivalents for the other ones (maybe not for this one either, as I think it is a good enough solution to throw an error rather than fail silently)
- I think it could be worth to make the same fix for apoc.trigger.add, either in this or a separate PR.
| @Test | ||
| public void testSubmitWithSchemaOperation() { | ||
| try { | ||
| testCall(db, "CALL apoc.periodic.submit('subSchema','CREATE INDEX periodicIdx FOR (n:Bar) ON (n.first_name, n.last_name)')", |
There was a problem hiding this comment.
When you cherry-pick to 4.x, it would be good to also add a test for CALL db.createUniquePropertyConstraint (that has been removed in Neo4j 5.0) to make sure this fix the original reported issue.
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Oct 18, 2022
…ns (neo4j/apoc#208) * Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (core) * removed unused import
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Oct 25, 2022
…ns (neo4j/apoc#208) (#3234) * Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (neo4j/apoc#208) * Fixes neo4j/apoc#126: Improve validateQuery (neo4j/apoc#218)
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Oct 25, 2022
…ns (neo4j/apoc#208) (neo4j-contrib#3234) * Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (neo4j/apoc#208) * Fixes neo4j/apoc#126: Improve validateQuery (neo4j/apoc#218)
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Oct 25, 2022
…ns (neo4j/apoc#208) (#3234) (#3246) * Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (neo4j/apoc#208) * Fixes neo4j/apoc#126: Improve validateQuery (neo4j/apoc#218) * removed unused imports * fixed full compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126 (core part)
Added QueryType validations in
validateQuery()method, so as to fail if the procedure tries to execute schema operationsRefactored
apoc.periodic.submitcode in order to be reused in extended.In Fixes neo4j/apoc#126: apoc.periodic.submit fails with schema operations (extended) neo4j-contrib/neo4j-apoc-procedures#3211, added
apoc.periodic.submitSchemaprocedure, equivalent but with differentvalidateQuery()andorg.neo4j.procedure.Mode.SCHEMANOTE FOR REVIEWER:
apoc.trigger.addhas thevalidateQuery(), maybe can be changed in the same way? (also in this case, perhaps in another pr)