Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for tx termination #155

Closed
6 tasks
neo-technology-build-agent opened this issue Sep 1, 2022 · 2 comments · Fixed by #256
Closed
6 tasks

check for tx termination #155

neo-technology-build-agent opened this issue Sep 1, 2022 · 2 comments · Fixed by #256
Labels
Larus

Comments

@neo-technology-build-agent
Copy link
Collaborator

Issue by jexp
Thursday Apr 06, 2017 at 11:37 GMT
Originally opened as neo4j-contrib/neo4j-apoc-procedures#375

  • Periodic
  • Graph Refactorings
  • The new renaming methods
  • cypher.runFile
  • exports
  • load.json, load.jdbc, load.xml

In a sensible place in the outmost loop that's iterate a reasonable number of times.
@neo-technology-build-agent
Copy link
Collaborator Author

Comment by jexp
Thursday Jul 06, 2017 at 13:51 GMT

Two more thoughts:

what do we do:

  1. abort
  2. return what we have (needed e.g. for runTimeboxed() or mapParallel )

also there is a difference between read and write operations

there could be also a central check, e.g. Util.inTx() that checks for abortion, but then we have to carry over the original kernel-tx (or wrapped in an interface) to the place where to check.

@neo-technology-build-agent
Copy link
Collaborator Author

Comment by jexp
Saturday Jul 29, 2017 at 09:51 GMT

@AngeloBusato See also the approach that we took in graph algorithms:
Issue: neo4j-contrib/neo4j-graph-algorithms#196
and related PRs

vga91 added a commit to vga91/apoc that referenced this issue Nov 28, 2022
@vga91
[HFWBmuq2] Fixes neo4j#155: Check for correct tx terminations
2c9dc44
@vga91 vga91 mentioned this issue Nov 28, 2022
Merged
vga91 added a commit that referenced this issue Dec 9, 2022
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
7cbbb1c
vga91 added a commit that referenced this issue Dec 15, 2022
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
bc7106f
vga91 added a commit that referenced this issue Jan 3, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
8bef9fe
vga91 added a commit that referenced this issue Jan 5, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
539dcaf
@vga91 vga91 mentioned this issue Jan 5, 2023
Closed
vga91 added a commit that referenced this issue Jan 12, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
859e5d2
vga91 added a commit that referenced this issue Jan 17, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
3be07f7
vga91 added a commit that referenced this issue Jan 23, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
d5ee589
vga91 added a commit that referenced this issue Feb 14, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
333362d
vga91 added a commit that referenced this issue Feb 15, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
a77506d
vga91 added a commit that referenced this issue Feb 17, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
9b33b51
vga91 added a commit that referenced this issue Feb 21, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations
303f8d5
vga91 added a commit that referenced this issue Feb 27, 2023
@vga91
[HFWBmuq2] Fixes #155: Check for correct tx terminations (#256)
ab6d58a 
* [HFWBmuq2] Fixes #155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue Apr 17, 2023
@vga91
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
817ed82 
…eo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue May 17, 2023
@vga91
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
c6404a7 
…eo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue Jun 21, 2023
@vga91
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
3083d9f 
…eo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue Jun 27, 2023
@vga91
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
482f1ff 
…eo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors
vga91 added a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue Jun 29, 2023
@vga91
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
e38e43a 
…eo4j/apoc#256) (#3534)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (neo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors

* [HFWBmuq2] [Bc2lkk3N] Fixed testImportCsvTerminate and added TerminationGuard to apoc.import.csv (neo4j/apoc#343)

* [Bc2lkk3N] Fix testImportCsvTerminate and add TerminationGuard to apoc.import.csv

* [Bc2lkk3N] Fix failing tests

* [Bc2lkk3N] Fix typo

* [HFWBmuq2] fix compile error

* [HFWBmuq2] remove imports

* [HFWBmuq2] fix flaky Timeboxed error

* [HFWBmuq2] removed unused imports
BennuFire pushed a commit to BennuFire/neo4j-apoc-procedures that referenced this issue Jul 10, 2023
@vga91 @BennuFire
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
c817cfa 
…eo4j/apoc#256) (neo4j-contrib#3534)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (neo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors

* [HFWBmuq2] [Bc2lkk3N] Fixed testImportCsvTerminate and added TerminationGuard to apoc.import.csv (neo4j/apoc#343)

* [Bc2lkk3N] Fix testImportCsvTerminate and add TerminationGuard to apoc.import.csv

* [Bc2lkk3N] Fix failing tests

* [Bc2lkk3N] Fix typo

* [HFWBmuq2] fix compile error

* [HFWBmuq2] remove imports

* [HFWBmuq2] fix flaky Timeboxed error

* [HFWBmuq2] removed unused imports
BennuFire pushed a commit to neo4j-contrib/neo4j-apoc-procedures that referenced this issue Jul 10, 2023
@vga91 @BennuFire
[HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (n…
e230dbc 
…eo4j/apoc#256) (#3534)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations (neo4j/apoc#256)

* [HFWBmuq2] Fixes neo4j/apoc#155: Check for correct tx terminations

* [HFWBmuq2] Code clean

* [HFWBmuq2] removed unused code

* [HFWBmuq2] try solving flaky tests

* [HFWBmuq2] changes review - added time check

* [HFWBmuq2] added local file tests - small changes

* [HFWBmuq2] removed unused imports after rebase

* [HFWBmuq2] fix flaky transaction not found error

* [HFWBmuq2] Fix heapspace and flaky errors

* [HFWBmuq2] [Bc2lkk3N] Fixed testImportCsvTerminate and added TerminationGuard to apoc.import.csv (neo4j/apoc#343)

* [Bc2lkk3N] Fix testImportCsvTerminate and add TerminationGuard to apoc.import.csv

* [Bc2lkk3N] Fix failing tests

* [Bc2lkk3N] Fix typo

* [HFWBmuq2] fix compile error

* [HFWBmuq2] remove imports

* [HFWBmuq2] fix flaky Timeboxed error

* [HFWBmuq2] removed unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Larus
Projects
None yet
Milestone
No milestone
1 participant
@neo-technology-build-agent