Remove dependency for neo4j-logging in our tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy2003
added
bug
Including an update to `neo4j-logging` which shaded Log4j2 which is subject to CVE-2021-44228 resolves #260
Andy2003
force-pushed
the
bugfix/gh-260-remove-dependency-for-neo4j-logging
branch
from
701f14e to
d6f1d68
Compare
Andy2003
deleted the
bugfix/gh-260-remove-dependency-for-neo4j-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neo4j-loggingshaded Log4j2 which is subject to CVE-2021-44228. Since we use it only in the test scope, it is safe to remove this dependency as long as all tests are still green.resolves #260