Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize graphql framework to handle fragments correctly #248

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

Andy2003
Copy link
Collaborator

With this change the way we handle projections is changed. We now rely on the graphql framework to parse fragments an arguments. This will simplify handling nested result fields like they are used in the javascript version of this library.

@Andy2003 Andy2003 added the enhancement New feature or request label Nov 16, 2021
@github-actions
Copy link

github-actions bot commented Nov 16, 2021

Unit Test Results

    4 files  ±0      4 suites  ±0   29s ⏱️ -2s
185 tests ±0  181 ✔️ ±0  4 💤 ±0  0 ±0 
719 runs  +2  713 ✔️ +2  6 💤 ±0  0 ±0 

Results for commit ab0f96e. ± Comparison against base commit 7e45a7a.

♻️ This comment has been updated with latest results.

@Andy2003 Andy2003 force-pushed the let_graphql_handle_selection branch 2 times, most recently from 17bf293 to 6057d64 Compare November 16, 2021 17:52
With this change the way we handle projections is changed. We now rely on the graphql framework to parse fragments an arguments. This will simplify handling nested result fields like they are used in the javascript version of this library.
@Andy2003 Andy2003 force-pushed the let_graphql_handle_selection branch from 6057d64 to ab0f96e Compare November 16, 2021 22:52
@Andy2003 Andy2003 merged commit 7ac1c04 into master Nov 16, 2021
@Andy2003 Andy2003 deleted the let_graphql_handle_selection branch November 16, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant