Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This bugfix solves a problem where inverse relationships were incorrectly mapped #123

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented Sep 3, 2020

{
  player{
    id
    memberships {
      team {
        id
      }
      prop
    }
  }
}

was mapped to

MATCH (player: Player)
RETURN player {
  .id,
  memberships: [(player)<-[playerMemberships: MEMBER_OF]-(playerMembershipsPlayer: Player) | playerMemberships {
    team: playerMembershipsPlayer { .id },
    .prop
  }]
} AS player

but

MATCH (player: Player)
RETURN player {
  .id,
  memberships: [(player)-[playerMemberships: MEMBER_OF]->(playerMembershipsTeam: Team) | playerMemberships {
    team: playerMembershipsTeam { .id },
    .prop
  }]
} AS player

is expected

@Andy2003 Andy2003 requested a review from jexp September 3, 2020 06:22
@jexp
Copy link
Contributor

jexp commented Sep 3, 2020

Looks good thanks a lot!

@jexp jexp merged commit b419d00 into neo4j-graphql:master Sep 3, 2020
@Andy2003 Andy2003 deleted the bugfix/relationship-direction branch September 3, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants