Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom scalars #9

Closed
jexp opened this issue Jan 21, 2019 · 4 comments · Fixed by #99
Closed

support custom scalars #9

jexp opened this issue Jan 21, 2019 · 4 comments · Fixed by #99
Assignees

Comments

@jexp
Copy link
Contributor

jexp commented Jan 21, 2019

  • todo how do we to the mapping / coercion?
  • should that be a client side concern
  • do we need additional directives or @cypher?
  • can we go with some valueOf/toString from the JVM?

see in the javascript library

@jexp jexp added this to the Release Candidate 1 milestone Jun 1, 2019
@jexp
Copy link
Contributor Author

jexp commented Jun 28, 2019

optional perhaps with a directive ....

scalar Foo @convert(parse:"return toInteger(value)", format: "....")

also talk to Will / Michael

@jexp
Copy link
Contributor Author

jexp commented Jun 28, 2019

Only do pass-through with NoOpCocerce for now

@jexp
Copy link
Contributor Author

jexp commented Jun 28, 2019

Perhaps it already works out of the box, whcih we should see with a simple test.

@jexp jexp assigned Andy2003 and unassigned conker84 Aug 24, 2019
Andy2003 added a commit to Andy2003/neo4j-graphql-java that referenced this issue Aug 3, 2020
Andy2003 added a commit to Andy2003/neo4j-graphql-java that referenced this issue Aug 3, 2020
@jexp jexp closed this as completed in #99 Aug 6, 2020
jexp added a commit that referenced this issue Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants