Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with optimized FILTER_AS_MATCH strategy #163

Closed
limejuly opened this issue Jan 28, 2021 · 2 comments · Fixed by #173
Closed

problem with optimized FILTER_AS_MATCH strategy #163

limejuly opened this issue Jan 28, 2021 · 2 comments · Fixed by #173
Assignees

Comments

@limejuly
Copy link
Contributor

limejuly commented Jan 28, 2021

Back ground: version 1.2.0, using FILTER_AS_MATCH strategy
Problem: Querying any argument that is not "filter" will be ignored.
for example, what I query is:

{
  product(id:"product8") {
     id
  }
}

And the "id" argument is ignored.

In the previous version, non filter arguments will make FILTER_AS_MATCH fail, so one can fall back to normal strategy. But now it is not failing, neither does it handle them.

Is that the expected behavior or am I using it wrong?

The corresponding change is #153

@Andy2003
Copy link
Collaborator

@limejuly can you create a test case for your issue please

@limejuly
Copy link
Contributor Author

limejuly commented Feb 5, 2021

@Andy2003 Hello, I have created a test case, please let me know if it is not valid.

@Andy2003 Andy2003 self-assigned this Feb 8, 2021
Andy2003 added a commit to Andy2003/neo4j-graphql-java that referenced this issue Mar 3, 2021
Andy2003 pushed a commit to Andy2003/neo4j-graphql-java that referenced this issue Mar 4, 2021
Andy2003 added a commit to Andy2003/neo4j-graphql-java that referenced this issue Mar 4, 2021
@jexp jexp closed this as completed in #173 Mar 25, 2021
jexp pushed a commit that referenced this issue Mar 25, 2021
…ring (#173)

* Create gh-163.adoc

* Allow optimized FILTER_AS_MATCH strategy to be used with simple filtering.

resolves #163

Co-authored-by: limejuly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants