-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added apoc.load.ldap #537
added apoc.load.ldap #537
Conversation
did you add that info to the docs and the error message when loading the ldap classes? |
@@ -72,6 +72,8 @@ dependencies { | |||
compile 'com.jayway.jsonpath:json-path:2.2.0' | |||
compileOnly group: 'net.biville.florent', name: 'neo4j-sproc-compiler', version:'1.2' | |||
|
|||
compile 'com.novell.ldap:jldap:2009-10-07' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be compileOnly + testOnly imho,
otherwise it's packaged into the jar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with this and I still needed the ldap.jar in the plugins folder. And yes it is mentioned in the doc
|
||
import java.util.Map; | ||
|
||
public class LDAPResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use MapResult instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are there other useful columns that makes sense to add? like data provenance ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did this to have the name 'entry' which is more reflecting the ldap name LDAPEntry. But technically we could also use MapResult. Then the examples have to be changed.
return config; | ||
|
||
} else { | ||
return (Map<String,Object> ) conn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if it is really a map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use a ldap:// URL instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ldap:// url is not convenient it has also a kind of search syntax in it (so it is more than a connection alone) I only need the connection parameters, search we do via the 'searchMap'
when you want to use this on neo4j server you have to put an jldap.jar in the plugins folder. You can get that via this url : https://mvnrepository.com/artifact/com.novell.ldap/jldap/2009-10-07