Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding apoc.debug.log with user function for logging out messages #529

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Adding apoc.debug.log with user function for logging out messages #529

merged 1 commit into from
Aug 23, 2017

Conversation

bradnussbaum
Copy link
Contributor

Some initial thoughts for debug to think on...

@jexp
Copy link
Member

jexp commented Aug 2, 2017

Some comments:

  • add global apoc config setting for logging
  • add a util helper method for checking the config setting and using the passed in @Context Log
  • add apoc.log.<error,warn,info,debug>(message, [params=[]]) void procedures that also honor the log setting
  • add debug logging to relevant procedures, like periodic iterate, load.jdbc and others

@bradnussbaum
Copy link
Contributor Author

@jexp

  1. For settings I think best behavior is to use the global logging unless users have specifically configured an apoc logging level. What is the property for the apoc logging level? I think logging should be configurable at least to the package level to enable silencing higher levels of logging.
  2. I think the scope of this PR should just be introduce the core logging capabilities so we can add logging support to each package i.e. periodic with logging level configuration. This PR will otherwise get very big and may never get merged.

@jexp
Copy link
Member

jexp commented Aug 2, 2017

There is no log-level config for apoc yet, not sure if the neo4j log level is even configurable.

Agreed on separating the individual logging out.

@bradnussbaum
Copy link
Contributor Author

bradnussbaum commented Aug 23, 2017

@jexp Is there a reason this cannot be merged now? We are using this a lot now. Maybe there are other enhancements but I'd rather not have to maintain merging in this separate branch all the time.

@jexp
Copy link
Member

jexp commented Aug 23, 2017

Oh sorry. I only saw the single commit. So I thought you didn't update it :)
I'll merge it.

@jexp jexp merged commit 58c74a0 into neo4j-contrib:3.1 Aug 23, 2017
@bradnussbaum
Copy link
Contributor Author

@jexp thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants