Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4242: The Pinecone APOC implementation is misleading #4250

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fixes #4242: The Pinecone APOC implementation is misleading #4250

merged 2 commits into from
Dec 2, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Nov 26, 2024 •
edited
Loading

Fixes #4242

  • Changed collection references to indexe ones,
    except to createCollection and deleteCollection names, to be consistent with other vector db procedures

  • Moved NOTE about collection naming on the top of the documentation.

The Pinecone APIs are changed meanwhile, therefore we:

  • increased Thread.sleeps where needed
  • changed endpoints
  • changed testCall to testRetryCallEventually where needed

RobertoSannino
RobertoSannino reviewed Dec 2, 2024
View reviewed changes
docs/asciidoc/modules/ROOT/pages/database-integration/vectordb/pinecone.adoc Outdated
@@ -1,24 +1,32 @@

= Pinecone

[NOTE]
====
The procedures create/drop/handle an index, instead of a collection like the other vectordb procedures,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand the sentence, can we rewrite it to be more clear?

@RobertoSannino RobertoSannino merged commit b24d774 into dev Dec 2, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the issue_4242 branch December 2, 2024 16:03
vga91 added a commit that referenced this pull request Dec 5, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
5cc4dff 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this pull request Dec 10, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading (#4250)
3120eee 
* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this pull request Dec 10, 2024
@vga91
Fixes #4242: The Pinecone APOC implementation is misleading (#4250) (#…
f25a569 
…4291)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this pull request Dec 16, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
08378f3 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this pull request Dec 19, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
bbd8ba0 
…4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc
vga91 added a commit that referenced this pull request Dec 20, 2024
@vga91
[NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#…
6228fae 
…4250) (#4275)

* [NOID] Fixes #4242: The Pinecone APOC implementation is misleading (#4250)

* Fixes #4242: The Pinecone APOC implementation is misleading

* Changes review pinecone.adoc

* [NOID] various fixes - added pinecone handler

* [NOID] add license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertoSannino RobertoSannino RobertoSannino left review comments

Assignees
No one assigned
Labels
dev extended-functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vga91 @RobertoSannino