Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Solve LoadHtml failing test due to string comparison (#3921) #3926

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jan 24, 2024

Cherry-pick 348f6fd

@vga91 vga91 added cherry-picked This PR has been cherry-picked to the other active branches 4.4 extended-functionality labels Jan 24, 2024
@vga91 vga91 force-pushed the 4.4-solve-loadhtml-failing-test-due-to-string-comparison branch from 67cad4a to fa81917 Compare January 25, 2024 13:31
@vga91 vga91 changed the title Solve LoadHtml failing test due to string comparison (#3921) [NOID] Solve LoadHtml failing test due to string comparison (#3921) Jan 25, 2024
@vga91 vga91 force-pushed the 4.4-solve-loadhtml-failing-test-due-to-string-comparison branch 3 times, most recently from e330df8 to 91e3749 Compare March 10, 2024 20:05
vga91 added 2 commits March 11, 2024 09:29
* Solve LoadHtml assertionError due to string comparison

* added browser not installed assertion

* Changed other string assertions
@vga91 vga91 force-pushed the 4.4-solve-loadhtml-failing-test-due-to-string-comparison branch from 91e3749 to adece39 Compare March 11, 2024 08:29
@vga91 vga91 merged commit d141160 into 4.4 Mar 11, 2024
12 checks passed
@vga91 vga91 deleted the 4.4-solve-loadhtml-failing-test-due-to-string-comparison branch March 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 cherry-picked This PR has been cherry-picked to the other active branches extended-functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant