-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various 5.11 build errors #3722
Conversation
9cff46a
to
ca66bc6
Compare
0ca8b9f
to
4a45136
Compare
a903bbb
to
7b24b7c
Compare
// if in sys-db there is a Procedure with the same name of the Function, or vice versa, | ||
// we re-register it, because the above unregister method delete every fun and proc with that name. | ||
// we use `registerWithoutOverride` to avoid recursion | ||
readSignatures().filter(i -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who guarantees that here there are both the procs/funcs?
I mean you're removing at line 374 the proc/func with signature custom.map_data
, who guarantees that the same procedure is not returned by readSignatures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to exclude the signatureName
from the records returned by readSignatures
4579312
to
7830bfe
Compare
* Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms
* Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms
* Solve no suitable method found for register * Re-register homonym fun/proc * lightened tests * lightened tests * try include only Startup * ignore provisionally startup with extra-deps tests * restore ExtendedTestContainerUtil * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix various 5.11 build errors (#3722) * Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms * Removed unused imports * Fix CypherEnterpriseExtendedTest similarly to 5.11 one
* Solve no suitable method found for register * Re-register homonym fun/proc * lightened tests * lightened tests * try include only Startup * ignore provisionally startup with extra-deps tests * restore ExtendedTestContainerUtil * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix various 5.11 build errors (neo4j-contrib#3722) * Fix various 5.11 build errors * small comment changes * excluded some hadoop deps to avoid conflict with neo4j 5.11 lib deps * Fix failing path traversal CI tests * Add explicit mockito test dependency * Generalized html with js error - it depends on the driver version * added parquet procs to extended.txt * wip - include only StartupExtendedTest * restored build.gradle * Added Extended annotation * Added Extended annotation * Added Extended annotation * Updated com.diffplug.spotless version * restore spotless * Fix custom proc with homonyms * Removed unused imports * Fix CypherEnterpriseExtendedTest similarly to 5.11 one
* [BqvAC2FK] Update selenium dependencies (#3663) * [BqvAC2FK] Update selenium dependencies * [BqvAC2FK] solve deps conflicts * [BqvAC2FK] removed ext. dep * [BqvAC2FK] add testImplementation dep. * [BqvAC2FK] Fix failing LoadHtmlTest (#3722) * [BqvAC2FK] Updated again deps and excluded sub dependencies * [BqvAC2FK] spotlessApply changes
StartupExtendedTest assertion error
No parquet procs found in
checkCoreAndExtendedWithExtraDependenciesJars
andcheckExtendedWithExtraDependenciesJars
tests.Added parquet procs in extended.txt.
Added
@Extended
to LoadParquet and ImportParquet classes.Generalized html with js error messages
It could depend on the driver version
ExportExtendedSecurityTest errors
Manual cherry-pick of neo4j/apoc#464
CI Error solved: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5925227756/job/16064237048#step:5:2069
StartupExtendedTest conflict
Excluded some
extra-dependencies/hadoop/build.gradle
sub-dependencies which are included in 5.11 lib as well, to prevent conflict exception like here.CI Error solved: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5693341463/job/15432238158
Custom procedure error
Changed
globalProceduresRegistry.register(<Callable>, true)
(which allowed ) toglobalProceduresRegistry.register(<Callable>)
and addedglobalProceduresRegistry.unregister(signature.name());
in order to prevent
"Unable to register function/procedure, because the name
%sis already in use "
error.This happens because of this neo4j change
CI Error solved:
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5585556876/jobs/10208445586?pr=3605#step:6:199
Added a card to check for a better resolution: https://trello.com/c/88y38wtZ/64-check-for-better-resolution
Custom procedure 2nd error
Removed
globalProceduresRegistry.lookupComponentProvider(Transaction.class, true);
andtransactionComponentFunction.apply(ctx);
,and added
Transaction tx = ctx.transaction();
insteadCI Error solved:
See https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5622346308/job/15234835763?pr=3666#step:6:203
Flaky CI termination without errors
Lightened
extended/src/test/resources/long-create.cypher
, which flakily interrupt the CI without errors, this could be due to a heap space memory error.Cherry-pick #3666
Spotless error
The following seems to be a temporary server error which now appears to be resolved.
https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/5944955989/job/16123319880?pr=3722#step:5:59