Fixes #3640: Custom procedures declaration fails in 5.x #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
issue-3640
branch
2 times, most recently
from
0b11b0d to
1194caa
Compare
vga91
changed the title
vga91
added a commit
that referenced
this pull request
Jul 21, 2023
vga91
added a commit
that referenced
this pull request
Jul 24, 2023
vga91
added a commit
that referenced
this pull request
Aug 22, 2023
vga91
added a commit
that referenced
this pull request
Aug 22, 2023
vga91
added a commit
that referenced
this pull request
Aug 22, 2023
recrwplay
pushed a commit
to recrwplay/neo4j-apoc-procedures
that referenced
this pull request
Aug 31, 2023
…eo4j-contrib#3647) * Fixes neo4j-contrib#3640: Custom procedures declaration fails in 5.9.0 * debug error in 5.10.0 * 5.10 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: in 5.10.0 the Signature is changed again. Waiting for release to check what is changedFixes #3640
The issue affects any
5.xversion.Sporadically the reflection finds 2 constructors and cycles starting with the one having 13 parameters, but in that case the following error is thrown, because it finds this constructor (which is btw
Deprecated) before the next non-deprecated one.Anyway, reflection should no longer be needed, since previously we could have e.g. an APOC 4.x compatible with Neo4j 4.x.y (with ProcedureSignature having 14 elements) and 4.x.z (with ProcedureSignature having 13 elements).
In Neo4j 5 it shouldn't happen, because, for example, APOC 5.9.0 is compatible with Neo4j 5.9.x, and theoretically, as it says here, the
xversion increments only in case of hotfixes, therefore should not cause breaking changes.Tried adding some junit tests, with both enterprise and docker, but it always works as it starts cycling starting the 14-element one first, even if you try restarting the database several times