[TFMonhHx] Forces new version of netty #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
added
cherry-picked
ncordon
force-pushed
the
4.4-bumps-netty-version
branch
from
fe30339 to
1207bff
Compare
BennuFire
pushed a commit
to BennuFire/neo4j-apoc-procedures
that referenced
this pull request
Jul 10, 2023
BennuFire
pushed a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks neo4j/apoc#450
What
This PR needs to be merged in conjunction with the latest version of the database
It makes possible to use the latest version of netty.
The issue is reproduced in a592576 and we can see how 2f0a268 solves it.
Why
A class was renamed changed between the
4.1.93.Finalversion of netty and4.1.94.Final, which neo4j is intending to use. We depend on arrow, which was only updated (but not released) 2 weeks ago, so the netty dependency there needs to be an old one.The only way to do this is to copy the file available in arrow and override it with the name change
PoolThreadCachetoPoolArenasCachetemporarily until arrow has been released.