[drqYtb6r] apoc.cypher.run* procedures don't return results (extended) #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added
5.9
cherry-picked
vga91
force-pushed
the
5.9-apoc-cypher-run-with-return-extended
branch
from
460e4df to
5373354
Compare
vga91
removed
the
cherry-picked
vga91
changed the title
vga91
force-pushed
the
5.9-apoc-cypher-run-with-return-extended
branch
4 times, most recently
from
ee5791d to
9e8be28
Compare
vga91
force-pushed
the
5.9-apoc-cypher-run-with-return-extended
branch
from
9e8be28 to
3c20805
Compare
conker84
reviewed
Jun 16, 2023
| @@ -385,7 +387,7 @@ public Stream<MapResult> parallel2(@Name("fragment") String fragment, @Name("par | |||
| } | |||
| return futures.stream().flatMap(f -> { | |||
| try { | |||
| return f.get().stream().map(MapResult::new); | |||
| return EntityUtil.anyRebind(tx, f.get()).stream().map(MapResult::new); | |||
There was a problem hiding this comment.
We need to do the entity rebind of the result f.get() (which can be a Map.of("key", <ENTITY>) )
in order to avoid the error The transaction has been closed.,
e.g. with the testCypherParallel2WithResults case.
|
@vga91 do we need to rebind also other methods like |
The other procedures work also without rebind. I created tests similar to |
conker84
approved these changes
Jun 16, 2023
vga91
added a commit
that referenced
this pull request
Jun 19, 2023
vga91
added a commit
that referenced
this pull request
Jun 19, 2023
vga91
added a commit
that referenced
this pull request
Jun 19, 2023
vga91
added a commit
that referenced
this pull request
Jun 19, 2023
* [drqYtb6r] apoc.cypher.run* procedures don't return results (neo4j/apoc#431) * [drqYtb6r] apoc.cypher.run* procedures don't return results * [drqYtb6r] fixed docker tests * [drqYtb6r] added test with other apoc.cpyher.run* procedures * [drqYtb6r] apoc.cypher.run* procedures don't return results (extended) (#3624)
vga91
added a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apoc.cypher.parallelandapoc.cypher.runFile(s)CypherExtendedTesttoCypherEnterpriseExtendedTestapoc.cypher.*procedure to check other potential similar cases.