[NOID] Fix flaky ConfigTest #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
fix-flaky-ConfigTest
branch
3 times, most recently
from
6401f0a to
207be0f
Compare
ncordon
reviewed
May 4, 2023
Comment on lines
51
to
80
| @Rule | ||
| public final ProvideSystemProperty systemPropertyRule | ||
| = new ProvideSystemProperty("foo", "bar") | ||
| .and("apoc.import.enabled", "true") | ||
| .and("apoc.trigger.refresh", "2000") | ||
| .and("apoc.jobs.scheduled.num_threads", "4") | ||
| .and("apoc.static.test", "one") | ||
| .and("apoc.jdbc.cassandra_songs.url", "jdbc:cassandra://localhost:9042/playlist"); | ||
|
|
||
| @Rule | ||
| public DbmsRule db = new ImpermanentDbmsRule(); | ||
|
|
||
| @BeforeClass | ||
| public static void setUp() throws Exception { | ||
| final File conf = new File(directory, "apoc.conf"); | ||
| try (FileWriter writer = new FileWriter(conf)) { | ||
| writer.write(String.join("\n", | ||
| "foo=bar", | ||
| "apoc.import.enabled" + "=true", | ||
| TRIGGER_REFRESH + "=2000", | ||
| APOC_CONFIG_JOBS_SCHEDULED_NUM_THREADS + "=4", | ||
| "apoc.static.test=one", | ||
| "apoc.jdbc.cassandra_songs.url=jdbc:cassandra://localhost:9042/playlist" | ||
| )); | ||
| } | ||
|
|
||
| System.setProperty(SUN_JAVA_COMMAND, "config-dir=" + directory.getAbsolutePath()); | ||
| } | ||
|
|
There was a problem hiding this comment.
How are we removing the flakiness here? I don't see the difference between writing the file to the file system and having those properties set.
Also the config that is causing issues in the CI, apoc.trigger.enabled is not among these.
There was a problem hiding this comment.
My initial idea was to give a shot using an "apoc.conf" like TriggerNewProceduresTest, which seems not to be flaky.
But rethinking about it, perhaps it is the latter that causes the flakyness,
since this line likely remains during the ConfigTest, hence the error.
Now I did the vice versa, ie changed all the tests that leverage the "apoc.conf" file consistently with the ConfigTest one.
ncordon
requested changes
May 4, 2023
vga91
force-pushed
the
fix-flaky-ConfigTest
branch
2 times, most recently
from
a265227 to
eb67260
Compare
vga91
force-pushed
the
fix-flaky-ConfigTest
branch
from
eb67260 to
942ce00
Compare
vga91
force-pushed
the
fix-flaky-ConfigTest
branch
from
942ce00 to
0397ee5
Compare
ncordon
approved these changes
May 5, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
May 19, 2023
* [NOID] Fix flaky ConfigTest * [NOID] changed apocConfig test handling
vga91
added a commit
that referenced
this pull request
May 19, 2023
* [NOID] Fix flaky ConfigTest * [NOID] changed apocConfig test handling
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
May 19, 2023
#414) * [NOID] Fix flaky ConfigTest * [NOID] changed apocConfig test handling
vga91
added a commit
that referenced
this pull request
May 22, 2023
* [NOID] Fix flaky ConfigTest * [NOID] changed apocConfig test handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.