[NOID] Fix flaky geocode server errors #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added
to-cherry-pick
gem-neo4j
reviewed
Apr 11, 2023
| } | ||
| throw e; | ||
| } | ||
| }, (value) -> value, 20L, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Just want to make sure I understood this correctly, this will retry to call the procedure if it gets a 502 etc until it gets a 200 for max 20 seconds? otherwise it will throw an error? :)
There was a problem hiding this comment.
I took a look at the failing tests, and both are to do with geocode, one is failing due to a 502 ;) might wanna check those out as well :)
vga91
force-pushed
the
fix-flaky-geocode-server-errors
branch
from
f168be6 to
ed1ee33
Compare
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Apr 14, 2023
…edures#3527) * [NOID] Fix flaky geocode server errors * [NOID] added waitForServerResponseOK in other test-cases, changed time measuring handling
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Apr 14, 2023
…edures#3527) (#372) * [NOID] Fix flaky geocode server errors * [NOID] added waitForServerResponseOK in other test-cases, changed time measuring handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
waitForServerResponseOKto prevent sporadic OpenStreetMap server errors.See: https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/4629830341/jobs/8190593821#step:7:1189