Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0L9VOhhh] Bumps apoc version after release #3495

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[0L9VOhhh] Bumps apoc version after release #3495

merged 1 commit into from
Mar 23, 2023

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Mar 17, 2023

No description provided.

@ncordon ncordon added 4.4 team-cypher-surface Cypher Surface team should review the PR labels Mar 17, 2023
@ncordon ncordon changed the title [NOID] Bumps apoc version [NOID] Bumps apoc version for release Mar 17, 2023
@ncordon ncordon changed the title [NOID] Bumps apoc version for release [NOID] Bumps apoc version after release Mar 17, 2023
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared with https://github.com/neo4j-contrib/neo4j-apoc-procedures/pull/3471/files and it looks like Nadja changed the apoc version in more files

@Lojjs Lojjs self-assigned this Mar 20, 2023
@ncordon ncordon changed the title [NOID] Bumps apoc version after release [0L9VOhhh] Bumps apoc version after release Mar 21, 2023
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I guess we will have to bump the Neo4j version in a separate PR when the CI starts failing because the docker version changed?

@ncordon
Copy link
Contributor Author

ncordon commented Mar 23, 2023

Looks fine. I guess we will have to bump the Neo4j version in a separate PR when the CI starts failing because the docker version changed?

I don't think the CI would fail in this case because these are released versions of neo4j, so they are fetched from Maven / docker repository. That does happen in the other repo for 5.x.

We are fine since the first step of the release card is to bump the neo4j version if there's a new one released publicly

@ncordon ncordon merged commit 3fd08d0 into 4.4 Mar 23, 2023
@ncordon ncordon deleted the bump-version branch March 23, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants