NO AUTO Strips refactor and periodic procedures from full #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
force-pushed
the
dev-strip-refactor-periodic
branch
2 times, most recently
from
076ec12 to
648f659
Compare
ncordon
force-pushed
the
dev-strip-refactor-periodic
branch
from
648f659 to
b50f00b
Compare
AzuObs
reviewed
Aug 3, 2022
| } else { | ||
| throw e; | ||
| } | ||
| } |
There was a problem hiding this comment.
Good catch.
I think this is fine for now, but it might be nice to think about how we should handle this type of stuff in the long term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
refactorandperiodicto core only.