Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO AUTO 5.0 remove deprecated apoc functionality #3064

Merged
merged 11 commits into from
Jul 28, 2022
Merged

NO AUTO 5.0 remove deprecated apoc functionality #3064

merged 11 commits into from
Jul 28, 2022

Conversation

gem-neo4j
Copy link
Contributor

@gem-neo4j gem-neo4j commented Jul 19, 2022 •
edited
Loading

Removed all procedures marked as deprecated and added a new page listing all removed with their replacement.

The commits are split into 3 parts:

  • First commit is the removal of the actual deprecated parts and tests
  • Second commit is the documentation removal for all deprecated parts
  • Third commit is the addition of the deprecation/removal document

@gem-neo4j gem-neo4j added 5.0 team-cypher-surface Cypher Surface team should review the PR labels Jul 19, 2022
@gem-neo4j
Copy link
Contributor Author

Remove deprecated APOC functionality

AzuObs
AzuObs reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this so far. I've suggested a few changes, which are mostly just the same thing repeated a few times.

AzuObs
AzuObs approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb job, thanks for the big clean up!

@AzuObs
Copy link
Contributor

AzuObs commented Jul 28, 2022

I'm going to merge this now if you don't mind. Because I need the changes which Nacho implemented in this branch, and to fix the incoming merge conflict in my APOC branch.

@AzuObs AzuObs merged commit a574e87 into dev Jul 28, 2022
@AzuObs AzuObs deleted the 5.0_remove_deprecated_apoc_functionality branch July 28, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzuObs AzuObs AzuObs approved these changes

Assignees

@AzuObs AzuObs

Labels
5.0 team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gem-neo4j @AzuObs @ncordon