Fix testLoadLDAP #3022
Merged
Fix testLoadLDAP #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
approved these changes
Jun 30, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Jun 30, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Jun 30, 2022
vga91
added a commit
that referenced
this pull request
Jun 30, 2022
Co-authored-by: Giuseppe Villani <[email protected]>
vga91
added a commit
that referenced
this pull request
Jun 30, 2022
Co-authored-by: Giuseppe Villani <[email protected]>
gem-neo4j
pushed a commit
to gem-neo4j/neo4j-apoc-procedures
that referenced
this pull request
Jul 12, 2022
Co-authored-by: Giuseppe Villani <[email protected]>
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be guessed, the
ldap.forumsys.comserver is not reachable at the moment, as we can see here.In this pr i used another online server.
Otherwise, to avoid possible similar errors in the future, maybe we could use an embedded mock server, such as https://github.com/zapodot/embedded-ldap-junit, or other test solutions.