Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes selenium tests in TeamCity (#3001) #3004

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Jun 22, 2022

Cherry-picks #3001

What

Excludes selenium tests from TeamCity if flag passed. The idea is to have two steps in the build:

1. gradlew test -PexcludeSeleniumTests
2. gradlew test --tests LoadHtmlTest --tests LoadHtmlTestParameterized

Why

So that we are able to have a different docker image for 1. and 2. The reason for that is some tests in 1. need to span a new docker container (dependencies, neo4j itself, etc), which requires root containers, and 2. explicitly requires non root access for emulating Chrome browsers (for safety reasons)

@ncordon ncordon added 4.2 cherry-picked This PR has been cherry-picked to the other active branches labels Jun 22, 2022
@ncordon ncordon merged commit c45b2ac into 4.2 Jun 22, 2022
@ncordon ncordon deleted the 4.2-exclude-selenium-tests branch June 22, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2 cherry-picked This PR has been cherry-picked to the other active branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant