Fixes #2748: apoc.temporal.toZonedTemporal missing in temporal docs page #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
requested changes
May 9, 2022
| @@ -273,7 +273,7 @@ This function parses a date string in a specified format and converts it to a Ne | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| This function has been renamed to `apoc.temporal.toZonedDateTime` and moved to the temporal section. | |||
| This function has been renamed to `apoc.temporal.toZonedTemporal` and moved to the temporal section. | |||
There was a problem hiding this comment.
Maybe this could be rephrased so it is even clearer thatapoc.date.parseAsZonedDateTime function is deprecated and apoc.temporal.toZonedTemporal is what should be used instead?
| @@ -48,7 +48,7 @@ Furthermore, we can specify a `maxDepth` to consider cycles with only `n` interm | |||
| MATCH (m1:Start) WITH collect(m1) as nodes CALL apoc.nodes.cycles(nodes, {maxDepth: 1}) YIELD path RETURN path | |||
| ---- | |||
|
|
|||
| image::cycles_max_depth_1.png | |||
| image::cycles_max_depth_1.png[width=800] | |||
There was a problem hiding this comment.
This change feels unrelated, was it intentional?
There was a problem hiding this comment.
Yes, without the [width=800] (more precisely without square brackets), the image is not rendered.
Lojjs
reviewed
May 11, 2022
| @@ -273,7 +273,7 @@ This function parses a date string in a specified format and converts it to a Ne | |||
|
|
|||
| [NOTE] | |||
| ==== | |||
| This function has been renamed to `apoc.temporal.toZonedDateTime` and moved to the temporal section. | |||
| This function has been deprecated by `apoc.temporal.toZonedTemporal`, therefore it's recommended to use this one instead. | |||
There was a problem hiding this comment.
Suggested change
| This function has been deprecated by `apoc.temporal.toZonedTemporal`, therefore it's recommended to use this one instead. | |
| This function has been deprecated by `apoc.temporal.toZonedTemporal`, therefore it's recommended to use that one instead. |
There was a problem hiding this comment.
I think this might be clearer?
Lojjs
approved these changes
May 18, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
May 19, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
May 19, 2022
vga91
pushed a commit
that referenced
this pull request
May 20, 2022
neo4j-oss-build
added a commit
that referenced
this pull request
May 20, 2022
vga91
pushed a commit
that referenced
this pull request
May 24, 2022
vga91
pushed a commit
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2748
Other docs fixes:
apoc.nodes.cycles.adoc