Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1570 #1576

Merged
Merged

Conversation

es50678
Copy link
Contributor

@es50678 es50678 commented Jul 1, 2020

Fixes #1570

Adds clarity into how UUID's are generated by apoc.create.uuid

Proposed Changes

A brief list of proposed changes in order to fix the issue:

  • Adds a one sentence paragraph that:
    • Explains how UUID's are generated under the hood
    • Provides links to the java method used to generated UUIDs and UUID RFC4122

Additional Information:

I built the plugin from source after my changes and realized the documentation changes wouldn't be there. Let me know if there is a good way for me to test this locally - my IDE provides a great adoc editor so I can see the changes look fine.

I also ran tests locally and everything passed. Since it's just a text change I don't know if I should add a test for this change, but if I should let me know.

Adds clarity into how UUID's are generated by `apoc.create.uuid`
@jexp jexp requested a review from mneedham July 1, 2020 23:38
@mneedham mneedham merged commit 14a49d0 into neo4j-contrib:4.0 Jul 9, 2020
mneedham pushed a commit that referenced this pull request Jul 9, 2020
Adds clarity into how UUID's are generated by `apoc.create.uuid`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Does apoc.create.uuid() conform to RFC4122?
2 participants